I think that Snape had a very good reason to be angry but he didn't have any right to put his hands on Harry. And come to that he also is still just a self loathing little boy inside. His inability to let go of the past and forgive and forget is clear evidence of that. The character has severe self esteem and self worth issues he desperately needs to address.